[IMPROVE] OAuth Role Sync#13761
[IMPROVE] OAuth Role Sync#13761geekgonecrazy merged 27 commits intoRocketChat:developfrom hypery2k:feature/oauth_groups_12243
Conversation
|
The error in circle seems to not being related to my changes: Any chance to get this merged into master? |
|
@geekgonecrazy ok for you? |
geekgonecrazy
left a comment
There was a problem hiding this comment.
Also please at least add the english i18n key for Accounts_OAuth_Custom_Merge_Roles don't need to bother with all the other languages in the scope of this PR
Co-Authored-By: hypery2k <[email protected]>
Co-Authored-By: hypery2k <[email protected]>
|
didn't get my circleci is failing. |
…pass user object around
|
circleci has been having a number of issues. :( I've pushed a commit making some slight changes.
|
|
thanks |
|
Just tried out with Okta. It works beautifully! :) Made one final adjustment |
|
great, i check it with latest keycloak and also works perfect. I will try to create another PR with some basic tests. |
|
Perfect! I think this PR is good to go then! :) Sorry your other PR didn’t get addressed. :( e2e testing would be great! But I think it would be incredibly difficult. Because would need an oauth provider that could consistently work in ci + provide roles. But if you want to open a Pr to add testing of any sort to oauth.. that would be fantastic. Maybe just unit tests to ensure all of this logic holds sound? |
see #12992