[FIX] users.getPreferences when the user doesn't have any preferences#13532
Merged
rodrigok merged 1 commit intoRocketChat:developfrom Apr 6, 2019
Conversation
rodrigok
requested changes
Mar 2, 2019
Contributor
Author
|
@rodrigok should I keep checking if is an empty object? |
Contributor
|
@thayannevls no, you can remove it. |
Contributor
|
@thayannevls can you please fix the conflicts? |
thayannevls
force-pushed
the
fix-getPreferences-when-user-doesnt-have-preferences
branch
from
e512d7c to
0cabdb7
Compare
Contributor
Author
|
@MarcosSpessatto Fixed it! Sorry for the delay. |
MarcosSpessatto
approved these changes
Mar 15, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12976
When normal users doesn't have any preferences,
user.settingsis an empty object instead of undefined. My solution was to check both.Maybe a better solution is all users start with settings as undefined.