[FIX] Fix rendering of links in the announcement modal#13250
Merged
engelgabriel merged 4 commits intoRocketChat:developfrom Apr 6, 2019
Merged
[FIX] Fix rendering of links in the announcement modal#13250engelgabriel merged 4 commits intoRocketChat:developfrom
engelgabriel merged 4 commits intoRocketChat:developfrom
Conversation
tassoevan
added
area: ui/ux
tassoevan
previously requested changes
Feb 16, 2019
Member
tassoevan
left a comment
tassoevan
left a comment
There was a problem hiding this comment.
Suggestion: use the same autolinker that parses links in messages.
Member
|
A better approach would be allowing markdown via our MD engine. |
Member
|
@rodrigok can we merge this? |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8021
@tassoevan @ggazzo In this PR, the links in the announce modal have been made clickable. I decided to use regex to make it identfy and render.