Regression: Fix message pinning#13213
Merged
sampaiodiego merged 1 commit intoRocketChat:masterfrom Jan 22, 2019
TkTech:fix_message_pinning
Merged
Regression: Fix message pinning#13213sampaiodiego merged 1 commit intoRocketChat:masterfrom TkTech:fix_message_pinning
sampaiodiego merged 1 commit intoRocketChat:masterfrom
TkTech:fix_message_pinning
Conversation
|
|
sampaiodiego
changed the title
sampaiodiego
approved these changes
Jan 22, 2019
Member
|
Awesome.. Good find.. Thank you 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #12739 added authentication checks for message pinning, however it does not actually work and will always error with not-authorized because it's checking a subscription-based role without providing the room ID.