[FIX] Notifications for mentions not working on large rooms and don't emit desktop notifications for offline users#13067
Merged
sampaiodiego merged 10 commits intodevelopfrom Jan 20, 2019
Merged
Conversation
…and using aggregate to avoid some 'ifs' on the server side
Member
|
@ggazzo please improve the PR title |
ggazzo
changed the title
Member
Author
|
@rodrigok anything more to say about the PR? |
tassoevan
reviewed
Jan 11, 2019
sampaiodiego
approved these changes
Jan 16, 2019
sampaiodiego
changed the title
sampaiodiego
changed the title
alansikora
pushed a commit
that referenced
this pull request
Jan 23, 2019
… emit desktop notifications for offline users (#13067)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we are trying to emit desktop/audio notifications even to offline users.