[IMPROVE] Improved support for OAuth Provider (WIP)#12992
Closed
hypery2k wants to merge 16 commits intoRocketChat:developfrom
Closed
[IMPROVE] Improved support for OAuth Provider (WIP)#12992hypery2k wants to merge 16 commits intoRocketChat:developfrom
hypery2k wants to merge 16 commits intoRocketChat:developfrom
Conversation
* read roles attribute from OpenID provider * still WIP see RocketChat#12243
Contributor
Author
|
any first thoughts on the changes? |
Contributor
Author
|
@Hudell the linting is failing, but has nothing really to do with my changes. What could I do to solve it? |
Contributor
Author
|
@Hudell So CI passes through now. Any chance to get the PR merged? |
Contributor
Author
|
@Hudell ping |
Contributor
Author
|
can anybody respond on the PR here? @rodrigok maybe? |
Contributor
Author
|
@Hudell any news? |
Contributor
Author
|
closed this PR in favor for #13761 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO:
Some Questions: