[IMPROVE] Change user presence events to streams and new REST endpoint to retrieve them#12800
Closed
sampaiodiego wants to merge 22 commits intodevelopfrom
Closed
[IMPROVE] Change user presence events to streams and new REST endpoint to retrieve them#12800sampaiodiego wants to merge 22 commits intodevelopfrom
sampaiodiego wants to merge 22 commits intodevelopfrom
Conversation
sampaiodiego
changed the title
sampaiodiego
added
docs
rodrigok
reviewed
Dec 7, 2018
| @@ -0,0 +1,7 @@ | |||
|
|
|||
| RocketChat.models.FullUser = new class extends RocketChat.models._Base { | |||
Member
There was a problem hiding this comment.
Why this separation, I didn't understand the idea.
Member
Author
There was a problem hiding this comment.
the issue is since I'm updating/inserting records on users collection on the client by hand, Meteor will throw out error if I subscribe to a publication that would add records to users collection.
so I had to change the fullUserData publication to publish on this new virtual collection.
sampaiodiego
commented
Dec 7, 2018
ggazzo
previously approved these changes
Dec 11, 2018
sampaiodiego
changed the title
Since only one instance can actual process the status change and call the callback, we need to broadcast that change to all instances
sampaiodiego
force-pushed
the
change-status-to-streams
branch
from
69a2773 to
30d94d9
Compare
Member
|
Please merge https://github.com/RocketChat/docs/pull/1026 when merging this |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing to streams will make it lighter on the client.
The first batch of online/away users will come from a REST request (thus will not flood websocket) and only further changes on status will come though DDP.
closes #11681