[NEW] Setting to set a JS/CSS CDN#11779
Merged
sampaiodiego merged 8 commits intodevelopfrom Aug 17, 2018
Merged
Conversation
geekgonecrazy
changed the title
sampaiodiego
approved these changes
Aug 17, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a setting to use a CDN just for JS/CSS assets aka the ones bundled.
The existing setting
CDN_PREFIXapplies across js,css,avatars,emoji and everything.The new setting
CDN_PREFIX_ALLis set to true by default to preserve that existing behaviour.But if you want to serve js/css from a different CDN prefix. Then you can set the new setting:
CDN_JSCSS_PREFIXand it will then only apply the prefix provided to the js/css files. In our case.. all of the meteor bundle js/css files 😄This will allow someone to start off and accelerate the js / css delivery speeding up initial paint. Then later on if they wish.. they can start using a CDN to cache more of their assets. This also gives them the power to combine as one CDN... or potentially use a couple of CDN's.
Power in the users hand. 😄