Skip to content

[FIX] Fix LDAP login by REST API, normal login and 2FA as well.#11731

Closed
MarcosSpessatto wants to merge 4 commits intodevelopfrom
fix-rest-ldap-login
Closed

[FIX] Fix LDAP login by REST API, normal login and 2FA as well.#11731
MarcosSpessatto wants to merge 4 commits intodevelopfrom
fix-rest-ldap-login

Conversation

@MarcosSpessatto
Copy link
Copy Markdown
Contributor

@MarcosSpessatto MarcosSpessatto commented Aug 9, 2018

Closes #5499
Closes #4961
Closes #7642
Closes #11411

and partially: #11570

@MarcosSpessatto MarcosSpessatto added this to the 0.69.0 milestone Aug 9, 2018
@MarcosSpessatto MarcosSpessatto self-assigned this Aug 9, 2018
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11731 August 9, 2018 19:18 Inactive
@suportecri1
Copy link
Copy Markdown

waiting for it so much!

Marcos Defendi added 2 commits August 17, 2018 15:23
rodrigok
rodrigok previously approved these changes Aug 20, 2018
Copy link
Copy Markdown
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This apparently breaks login via web to users with 2FA enabled even if login fallback enabled.

@toimtoimtoim
Copy link
Copy Markdown

toimtoimtoim commented Oct 1, 2018

It would be really nice to see this resolved, merged and released. We have LDAP in our corporate infrastructure and this problem blocks us creating CI bots using REST API.

currently only working way to use LDAP is to use undocumented features as

curl -s -H "Content-type:application/json" \
      ${ROCKET_URL}/api/v1/login \
      -d "{\"ldap\": true, \"username\": \"${ROCKET_USER}\", \"ldapPass\": \"${ROCKET_PASSWORD}\", \"ldapOptions\":{} }"

@theorenck theorenck modified the milestones: 0.69.0, Short-term Dec 12, 2018
@MarcosSpessatto
Copy link
Copy Markdown
Contributor Author

We must have this PR merged before working again on this one.
Depends of: #11726
Refs: #11570 (comment)

@engelgabriel
Copy link
Copy Markdown
Member

We may have fixed these issues on our latest refactoring. @rodrigok will check and update the PR and related issues.

@engelgabriel engelgabriel modified the milestones: 3.2.0, 3.3.0 May 9, 2020
@rodrigok rodrigok modified the milestones: 3.3.0, 3.4.0 May 21, 2020
@StarScream902
Copy link
Copy Markdown

I have the same problem with the login of Jenkins plugin for rocketchat to rocketchat server. But, the plugin connects, when rocketchat is set up without LDAP.
And I found this hidden login payload too

curl -s -H "Content-type:application/json" \
      ${ROCKET_URL}/api/v1/login \
      -d "{\"ldap\": true, \"username\": \"${ROCKET_USER}\", \"ldapPass\": \"${ROCKET_PASSWORD}\", \"ldapOptions\":{} }"

And this solution Is not suitable for me, because I need the working plugin

@rodrigok rodrigok modified the milestones: 3.4.0, 3.5.0 Jun 20, 2020
@TBG-FR
Copy link
Copy Markdown
Contributor

TBG-FR commented Oct 15, 2020

Any updates on this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

10 participants