[FIX] Fixing timeAgo function on directory#11728
Merged
Conversation
ggazzo
approved these changes
Aug 13, 2018
tassoevan
approved these changes
Aug 13, 2018
Merged
|
@rssilva |
Contributor
Author
|
@tahajahangir oh thank you for the heads up! I'll open a PR ASAP 😃 |
Contributor
Author
|
here we go #11946 |
ggazzo
pushed a commit
that referenced
this pull request
Sep 18, 2018
…ction (#11946) Related with #11663, but I added a bug removing `t` function on this PR 😬 #11728 Now we're translating 🗣 🌎 🌍 🌏 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #11663
Adding
timeAgofunction to ahelpersfile so we can test it because just importing it from the previous file will cause an errorTemplate is not defined. I reproduced the mentioned case on a test.