Skip to content

[FIX] Fixing timeAgo function on directory#11728

Merged
ggazzo merged 2 commits intodevelopfrom
fix-directory-showing-dates
Aug 13, 2018
Merged

[FIX] Fixing timeAgo function on directory#11728
ggazzo merged 2 commits intodevelopfrom
fix-directory-showing-dates

Conversation

@rssilva
Copy link
Copy Markdown
Contributor

@rssilva rssilva commented Aug 9, 2018

Fix #11663

Adding timeAgo function to a helpers file so we can test it because just importing it from the previous file will cause an error Template is not defined. I reproduced the mentioned case on a test.

@rssilva rssilva self-assigned this Aug 9, 2018
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11728 August 9, 2018 17:05 Inactive
@ggazzo ggazzo added the area: ui/ux Related to UI/UX, frontend code, accessibility, and user interaction label Aug 10, 2018
@ggazzo ggazzo added this to the 0.69.0 milestone Aug 10, 2018
@ggazzo ggazzo requested review from ggazzo and tassoevan August 10, 2018 20:09
@ggazzo ggazzo merged commit 94ad01f into develop Aug 13, 2018
@ggazzo ggazzo deleted the fix-directory-showing-dates branch August 13, 2018 19:12
@sampaiodiego sampaiodiego mentioned this pull request Aug 28, 2018
@tahajahangir
Copy link
Copy Markdown

@rssilva
The "yesterday" word was translated with t('yesterday'), but after this PR, it's the english word 'yesterday' in any language.

@rssilva
Copy link
Copy Markdown
Contributor Author

rssilva commented Sep 3, 2018

@tahajahangir oh thank you for the heads up! I'll open a PR ASAP 😃

@rssilva
Copy link
Copy Markdown
Contributor Author

rssilva commented Sep 4, 2018

here we go #11946

ggazzo pushed a commit that referenced this pull request Sep 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ui/ux Related to UI/UX, frontend code, accessibility, and user interaction

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants