Skip to content

[NEW] 2 Factor Authentication when using OAuth and SAML#11726

Merged
sampaiodiego merged 37 commits intodevelopfrom
2fa-for-all-authenticators
Nov 21, 2020
Merged

[NEW] 2 Factor Authentication when using OAuth and SAML#11726
sampaiodiego merged 37 commits intodevelopfrom
2fa-for-all-authenticators

Conversation

@Hudell
Copy link
Copy Markdown
Contributor

@Hudell Hudell commented Aug 9, 2018

Closes #9775
Closes #11731
Closes #6750
Closes #11570
Closes #5499
Closes #4961
Closes #7642
Closes #11411

This PR implements 2 Factor Authentication on all OAuth methods. Also includes 2FA for SAML and LDAP authentication.

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11726 August 9, 2018 14:08 Inactive
@Hudell Hudell added this to the Short-term milestone Aug 9, 2018
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11726 August 9, 2018 14:13 Inactive
Marcos Defendi added 2 commits August 9, 2018 15:51
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11726 August 11, 2018 15:00 Inactive
@engelgabriel engelgabriel modified the milestones: 3.1.0, 3.2.0 Apr 20, 2020
@engelgabriel engelgabriel requested a review from rodrigok May 7, 2020 16:27
@engelgabriel engelgabriel modified the milestones: 3.2.0, 3.3.0 May 9, 2020
@rodrigok rodrigok modified the milestones: 3.3.0, 3.4.0 May 21, 2020
@rodrigok
Copy link
Copy Markdown
Member

To support the new 2FA system with one-time login credentials (OAuth) needs to implement a new temporary mid-step authorization token (maybe a JWT) to proceed with the user's input of the 2FA code.

@rodrigok rodrigok self-assigned this Jun 19, 2020
@rodrigok rodrigok modified the milestones: 3.4.0, 3.5.0 Jun 20, 2020
@pierre-lehnen-rc pierre-lehnen-rc self-assigned this Nov 9, 2020
@pierre-lehnen-rc pierre-lehnen-rc modified the milestones: 3.5.0, 3.8.0 Nov 9, 2020
@pierre-lehnen-rc pierre-lehnen-rc modified the milestones: 3.8.0, 3.9.0 Nov 9, 2020
@lgtm-com

This comment has been minimized.

@sampaiodiego sampaiodiego merged commit 378ef37 into develop Nov 21, 2020
@sampaiodiego sampaiodiego deleted the 2fa-for-all-authenticators branch November 21, 2020 01:34
@sampaiodiego sampaiodiego mentioned this pull request Nov 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment