Skip to content

[FIX] Missing twitter:image and og:image tags#11687

Merged
ggazzo merged 2 commits intodevelopfrom
added-social-tags
Aug 15, 2018
Merged

[FIX] Missing twitter:image and og:image tags#11687
ggazzo merged 2 commits intodevelopfrom
added-social-tags

Conversation

@engelgabriel
Copy link
Copy Markdown
Member

No description provided.

@engelgabriel engelgabriel added this to the 0.69.0 milestone Aug 7, 2018
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11687 August 7, 2018 04:25 Inactive
<meta name="msapplication-TileImage" content="assets/tile_144.png" />
<meta name="msapplication-config" content="images/browserconfig.xml" />
<meta property="og:image" content="assets/favicon_512">
<meta property="twitter:image" content="assets/favicon_512">
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't it be better to add the file extension?

@ggazzo ggazzo added the area: ui/ux Related to UI/UX, frontend code, accessibility, and user interaction label Aug 7, 2018
@ggazzo ggazzo merged commit 1148d6c into develop Aug 15, 2018
@ggazzo ggazzo deleted the added-social-tags branch August 15, 2018 14:09
@ggazzo ggazzo restored the added-social-tags branch August 15, 2018 14:10
@ggazzo ggazzo deleted the added-social-tags branch August 15, 2018 14:10
@sampaiodiego sampaiodiego mentioned this pull request Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ui/ux Related to UI/UX, frontend code, accessibility, and user interaction

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants