[IMPROVE] Messagebox fix performance#11686
Conversation
rssilva
left a comment
rssilva
left a comment
There was a problem hiding this comment.
Awesome! 🔥
One small change and I think that we are good to go!
| * http://github.com/jaz303/jquery-grab-bag/tree/master/javascripts/jquery.autogrow-textarea.js | ||
| */ | ||
| $.fn.autogrow = function(options) { | ||
| var shadow = $("div.autogrow-shadow"); |
There was a problem hiding this comment.
Maybe we could add a TODO and investigate if there is a way to pass the container element to search this .autogrow-shadow class. Doing like this we are looking at the whole DOM.
There was a problem hiding this comment.
actually this code was a copy/paste thats why I'm not using >ES5 on code (just were I changed)
There was a problem hiding this comment.
and about the find, we can use body > .autogrow-shadow or use an id instead, but this code just runs "one time"(one time per opened room) so I dont think will change a lot, but I will change
|
It seems that the current:
this branch:
Also, take a look at the key down improvement 👀 |
ggazzo
changed the title
3 participants
should close #10583