[FIX] "User is typing" not working in new Livechat session#11670
Merged
sampaiodiego merged 1 commit intodevelopfrom Aug 14, 2018
Merged
[FIX] "User is typing" not working in new Livechat session#11670sampaiodiego merged 1 commit intodevelopfrom
sampaiodiego merged 1 commit intodevelopfrom
Conversation
…chat room was created.
sampaiodiego
approved these changes
Aug 14, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11235.
When a new Livechat room is created and the agent starts typing, the 'Typing indicator' is not displayed in the Livechat widget. The
Typing Indicatoris only displayed in case the visitor reloads the widget.This issue was happening because when a new Livechat session is started, the
visitor.getRoom (true)method assigns a newroomIdto the visitor object, but theroomthat will receive thisroomIdis not yet created on DB.To fix this issue, another
ReactiveVarwill be used to assign a callback inNotifications.onRoomto detect when the agent is typing. Thevisitor.getRoom()has been replaced byLivechat.room.