[IMPROVE] Add template tag #{userdn} to filter LDAP group member format#11662
Merged
sampaiodiego merged 1 commit intoRocketChat:developfrom Aug 13, 2018
crazy-max:develop
Merged
[IMPROVE] Add template tag #{userdn} to filter LDAP group member format#11662sampaiodiego merged 1 commit intoRocketChat:developfrom crazy-max:develop
sampaiodiego merged 1 commit intoRocketChat:developfrom
crazy-max:develop
Conversation
crazy-max
changed the title
crazy-max
changed the title
Contributor
Author
|
Hey guys, can you give me some feedback on this ? Thanks a lot! |
sampaiodiego
approved these changes
Aug 7, 2018
Contributor
Author
|
@sampaiodiego Will it be merged for the next minor release ? Thanks! |
sampaiodiego
changed the title
Member
|
@crazy-max only on next major (0.69) |
Contributor
Author
|
@sampaiodiego Ok thx |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases (including mine) LDAP servers use the full user dn to filter members belonging to a group.
Here by adding a template tag
#{userdn}composed of the complete DN of the user, we can easily translate this into the group member format to find it :Ping @rodrigok :)