[FIX] Regression in prune by user, and update lastMessage#11646
Merged
ggazzo merged 3 commits intoRocketChat:developfrom Aug 7, 2018
Merged
[FIX] Regression in prune by user, and update lastMessage#11646ggazzo merged 3 commits intoRocketChat:developfrom
ggazzo merged 3 commits intoRocketChat:developfrom
Conversation
vynmera
changed the title
sampaiodiego
added
the
area: ui/ux
ggazzo
approved these changes
Aug 7, 2018
sampaiodiego
pushed a commit
that referenced
this pull request
Aug 10, 2018
* Fix regression * Also update lastMessage * code style fix
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11607
Closes #11648
811b832 forgot to remove all usages of
Session, causing the users field to not be used.Furthermore, I forgot to update
lastMessagewhen pruning channels, so if the prune includes the latest message the database will hold wrong info.