[FIX] HipChat importer wasn’t compatible with latest exports#11597
Merged
sampaiodiego merged 2 commits intodevelopfrom Jul 31, 2018
Merged
[FIX] HipChat importer wasn’t compatible with latest exports#11597sampaiodiego merged 2 commits intodevelopfrom
sampaiodiego merged 2 commits intodevelopfrom
Conversation
sampaiodiego
approved these changes
Jul 30, 2018
sampaiodiego
pushed a commit
that referenced
this pull request
Jul 31, 2018
Merged
ubarsaiyan
pushed a commit
to ubarsaiyan/Rocket.Chat
that referenced
this pull request
Aug 15, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cloud export is now the same format of the enterprise one, so I changed the naming of the enterprise to
HipChat (tar.gz)and the old hiptchat cloud toHipChat (zip)to try to keep compatibility with who already have the old export.We may need to change the documentation https://rocket.chat/docs/administrator-guides/import/hipchat/enterprise/ and https://rocket.chat/docs/administrator-guides/import/hipchat/cloud/ @MartinSchoeler can you help on that? Let me know then we can discuss what to change.