[FIX] Fix broken uploaded images in cordova app#11573
Closed
ramrami wants to merge 1 commit intoRocketChat:developfrom
Closed
[FIX] Fix broken uploaded images in cordova app#11573ramrami wants to merge 1 commit intoRocketChat:developfrom
ramrami wants to merge 1 commit intoRocketChat:developfrom
Conversation
ggazzo
added
the
area: ui/ux
tassoevan
requested changes
Aug 13, 2018
Member
tassoevan
left a comment
tassoevan
left a comment
There was a problem hiding this comment.
Thanks, but I have some observations.
Internally, lazyloadImage template already uses fixCordova helper, but the rendered data-src attribute of the <img> seems to be ignored. I think we need to fix it there, not where lazyloadImage is used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uploaded images are not working in cordova build. I just added the missing call to
fixCordovafunction on theimage_url.thks