Regression: Make message popup user mentions reactive again#11567
Merged
Regression: Make message popup user mentions reactive again#11567
Conversation
tassoevan
added
area: ui/ux
tassoevan
changed the title
rodrigok
requested changes
Jul 26, 2018
| Meteor.startup(function() { | ||
| Tracker.autorun(function() { | ||
| if (Meteor.userId() == null || Session.get('openedRoom') == null) { | ||
| if (!Meteor.userId() || !Session.get('openedRoom')) { |
Member
There was a problem hiding this comment.
Can you move these 2 itens to variables and, test them here and use them below?
| })); | ||
|
|
||
| const registerNewUser = user => browser.executeAsync(({ name, email, username, password, isMentionable }, done) => { | ||
| setTimeout(() => Meteor.call('registerUser', { name, email, pass: password }, error => { |
Member
There was a problem hiding this comment.
Wouldn't be quicker to use API to create users and send messages?
https://github.com/RocketChat/Rocket.Chat/blob/develop/tests/end-to-end/api/01-users.js#L31
rodrigok
changed the title
rodrigok
approved these changes
Jul 27, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.