[FIX] Results pagination on /directory REST endpoint#11551
Merged
sampaiodiego merged 8 commits intodevelopfrom Aug 20, 2018
Merged
[FIX] Results pagination on /directory REST endpoint#11551sampaiodiego merged 8 commits intodevelopfrom
sampaiodiego merged 8 commits intodevelopfrom
Conversation
added 2 commits
August 17, 2018 15:41
fix wrong parameter in REST directory
sampaiodiego
requested changes
Aug 18, 2018
| } | ||
| const sortBy = sort ? Object.keys(sort)[0] : undefined; | ||
| const sortDirection = sort && Object.values(sort)[0] === 1 ? 'asc' : 'desc'; | ||
| const page = offset <= 0 ? 0 : Math.ceil(offset / count); |
Member
There was a problem hiding this comment.
the correct is to use Math.floor, using ceil page will never be 0.
also count should be tested to be greater than 0
added 2 commits
August 20, 2018 12:51
Fix wrong page calculus in REST directory
rodrigok
previously approved these changes
Aug 20, 2018
fix empty results when page or offset are equal zero
sampaiodiego
approved these changes
Aug 20, 2018
sampaiodiego
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11151