[FIX] Fix links in onTableItemClick of the directroy page#11543
Merged
ggazzo merged 7 commits intoRocketChat:developfrom Aug 20, 2018
Merged
[FIX] Fix links in onTableItemClick of the directroy page#11543ggazzo merged 7 commits intoRocketChat:developfrom
onTableItemClick of the directroy page#11543ggazzo merged 7 commits intoRocketChat:developfrom
Conversation
Contributor
Author
|
After executing 'Update Branch', some CI tests failed. It seems that my patch is not the cause, but does I need to take some actions? |
|
This is the last bug I have been waiting to be fixed to release this chat to my chat community. Does anyone know when this should be added to the master? |
ggazzo
added
the
area: ui/ux
ggazzo
approved these changes
Aug 14, 2018
Contributor
Author
|
Before to close this, please check PR #11781. |
ggazzo
approved these changes
Aug 20, 2018
|
When will this fix be added to the production release? |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix that subdir routing on the directory page is duplicated.
Related #10732.
Excuse me, This PR cannot fix all of #10732.