Skip to content

Revert: Mixed case channel slugs #9449#11537

Merged
sampaiodiego merged 2 commits intodevelopfrom
fix-default-tests
Jul 21, 2018
Merged

Revert: Mixed case channel slugs #9449#11537
sampaiodiego merged 2 commits intodevelopfrom
fix-default-tests

Conversation

@sampaiodiego
Copy link
Copy Markdown
Member

@sampaiodiego sampaiodiego commented Jul 21, 2018

Revert #9449 due to several broken tests.

Looks like a break change that should be better tested and documented.

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11537 July 21, 2018 03:14 Inactive
ggazzo
ggazzo previously approved these changes Jul 21, 2018
@sampaiodiego sampaiodiego changed the title [FIX] /channels.setDefault tests Revert: Mixed case channel slugs #9449 Jul 21, 2018
@sampaiodiego sampaiodiego merged commit e5190dd into develop Jul 21, 2018
@sampaiodiego sampaiodiego deleted the fix-default-tests branch July 21, 2018 05:00
@sampaiodiego sampaiodiego mentioned this pull request Jul 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants