Regression: Remove safe area margins from logos#11508
Merged
engelgabriel merged 3 commits intodevelopfrom Jul 19, 2018
Merged
Conversation
vynmera
reviewed
Jul 19, 2018
Contributor
vynmera
left a comment
vynmera
left a comment
There was a problem hiding this comment.
Thank you very much, it looks a lot better! You left some more Copy statements in your SVG tho, just FYI
| <path d="M69.925033,208.173342 C50.4407832,192.793554 38.7455021,173.112627 38.7455021,151.661726 C38.7455021,102.438964 100.327182,62.5360308 176.292035,62.5360308 C252.256887,62.5360308 313.838567,102.438964 313.838567,151.661726 C313.838567,200.884488 252.256887,240.787421 176.292035,240.787421 C157.569795,240.787421 139.72122,238.363631 123.452894,233.973894 L111.559161,245.463137 C105.096582,251.705932 97.5219247,257.355364 89.6264401,261.807163 C79.1610588,266.954973 68.8266947,269.763549 58.6022549,270.620523 C59.1790333,269.570206 59.7101411,268.506214 60.2802987,267.454244 C72.1977791,245.465877 75.4126905,225.705576 69.925033,208.173342 Z" id="bubble" fill="#FFFFFF"></path> | ||
| <path d="M110.48867,171.559023 C99.2955147,171.559023 90.2216692,162.515313 90.2216692,151.359331 C90.2216692,140.20335 99.2955147,131.15964 110.48867,131.15964 C121.681826,131.15964 130.755671,140.20335 130.755671,151.359331 C130.755671,162.515313 121.681826,171.559023 110.48867,171.559023 Z M175.738527,171.559023 C164.545372,171.559023 155.471526,162.515313 155.471526,151.359331 C155.471526,140.20335 164.545372,131.15964 175.738527,131.15964 C186.931683,131.15964 196.005529,140.20335 196.005529,151.359331 C196.005529,162.515313 186.931683,171.559023 175.738527,171.559023 Z M240.988385,171.559023 C229.795229,171.559023 220.721383,162.515313 220.721383,151.359331 C220.721383,140.20335 229.795229,131.15964 240.988385,131.15964 C252.18154,131.15964 261.255386,140.20335 261.255386,151.359331 C261.255386,162.515313 252.18154,171.559023 240.988385,171.559023 Z" id="circles" fill="#DB2323" fill-rule="nonzero"></path> | ||
| </g> | ||
| <g id="Icon--Copy" stroke="none" stroke-width="1" fill="none" fill-rule="evenodd"> |
public/images/logo/logo-dark.svg
Outdated
| <svg width="1000px" height="182px" viewBox="0 0 1000 182" version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink"> | ||
| <!-- Generator: Sketch 51 (57462) - http://www.bohemiancoding.com/sketch --> | ||
| <title>Logo</title> | ||
| <title>Artboard Copy</title> |
Contributor
There was a problem hiding this comment.
(there's some more in this file, in the g tags)
public/images/logo/logo.svg
Outdated
| <g id="Group-2" transform="translate(588.000000, 532.000000)" fill="#FFFFFF" fill-rule="nonzero"> | ||
| <g id="logo-type" transform="translate(721.000000, 87.000000)"> | ||
| <g id="Artboard" stroke="none" stroke-width="1" fill="none" fill-rule="evenodd"> | ||
| <g id="Group-2-Copy" transform="translate(0.000000, 1.000000)" fill="#FFFFFF" fill-rule="nonzero"> |
Member
|
I've changed the logo sizes and alignments, here's how it looks with my changes:
|
sampaiodiego
force-pushed
the
brunosquadros-patch-2
branch
from
dad3129 to
9910904
Compare
engelgabriel
approved these changes
Jul 19, 2018
sampaiodiego
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #ISSUE_NUMBER