[FIX] Invalid permalink URLs for Direct Messages#11507
Merged
sampaiodiego merged 4 commits intodevelopfrom Jul 21, 2018
Merged
Conversation
ggazzo
previously requested changes
Jul 19, 2018
Member
ggazzo
left a comment
ggazzo
left a comment
There was a problem hiding this comment.
packages/rocketchat-lib/lib/roomTypes/direct.js is used on server and client side, you cant run this code there
sampaiodiego
approved these changes
Jul 21, 2018
sampaiodiego
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11400
This PR makes two changes: First, it fixes the "Permalink" option to generate valid URLs on direct messages, where it was broken.
The second change is to make it so that permalinks on DMs work for both users on the conversation, regardless of which username is on the URL itself.