Skip to content

[NEW] Add /roles.list REST endpoint to retrieve all server roles#11500

Merged
sampaiodiego merged 2 commits intodevelopfrom
rest-all-roles
Jul 21, 2018
Merged

[NEW] Add /roles.list REST endpoint to retrieve all server roles#11500
sampaiodiego merged 2 commits intodevelopfrom
rest-all-roles

Conversation

@MarcosSpessatto
Copy link
Copy Markdown
Contributor

Closes #11312

Endpoint to retrieve all server roles
@MarcosSpessatto MarcosSpessatto added this to the 0.67.0 milestone Jul 18, 2018
@MarcosSpessatto MarcosSpessatto self-assigned this Jul 18, 2018
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11500 July 18, 2018 21:36 Inactive
@MarcosSpessatto
Copy link
Copy Markdown
Contributor Author

@cardoso Can you take a look please?

@vynmera
Copy link
Copy Markdown
Contributor

vynmera commented Jul 18, 2018

Wouldn't this fit better in permissions.roles? Or should they be seen as more separate things~

@MarcosSpessatto
Copy link
Copy Markdown
Contributor Author

@vynmera We can change it, without problems. But when we make an endpoint to update or create more roles will it make sense? What do you think?

@vynmera
Copy link
Copy Markdown
Contributor

vynmera commented Jul 19, 2018

@MarcosSpessatto Mmm, that's true. But then it would probably be better to change the name to roles.list, otherwise we'd have to change it again when we add new endpoints.

@theorenck theorenck modified the milestones: 0.67.0, 0.68.0 Jul 19, 2018
@MarcosSpessatto
Copy link
Copy Markdown
Contributor Author

@vynmera I agree, I'll change it. Thanks.

Change name of endpoint from /roles to /roles.list
@sampaiodiego sampaiodiego changed the title [NEW] Endpoint to retrieve all server roles [NEW] Add /roles.list REST endpoint to retrieve all server roles Jul 21, 2018
@sampaiodiego sampaiodiego merged commit d6caf53 into develop Jul 21, 2018
@sampaiodiego sampaiodiego deleted the rest-all-roles branch July 21, 2018 02:26
@sampaiodiego sampaiodiego mentioned this pull request Jul 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants