[NEW] Make WebRTC not enabled by default#11489
Merged
Conversation
MartinSchoeler
changed the title
ggazzo
approved these changes
Jul 17, 2018
Merged
|
Is WebRTC available now? there is no way to enable WebRTC video chat in channel. Even I enabled WebRTC in administration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on the video conferencing docs, I've noted the clear confusion of users between Jitsi and WebRTC methods. My suggestion is to make the the WebRTC options not default (like jitsi currently is) so if a server admin wants Video Conference he will have to set it up one of those, instead of using the currently preset default. I believe that this plus the upcoming docs PR that explains the difference between each other and how to set them up will greatly help reduce this confusion.
Link to documentation: https://github.com/RocketChat/docs/pull/841