Skip to content

[NEW] Room files search form#11486

Merged
ggazzo merged 24 commits intodevelopfrom
fix.room-files
Jul 19, 2018
Merged

[NEW] Room files search form#11486
ggazzo merged 24 commits intodevelopfrom
fix.room-files

Conversation

@tassoevan
Copy link
Copy Markdown
Member

@tassoevan tassoevan commented Jul 17, 2018

Closes #6411
Closes #9150
Closes #9557

@tassoevan tassoevan added type: bug area: ui/ux Related to UI/UX, frontend code, accessibility, and user interaction type: improvement labels Jul 17, 2018
@tassoevan tassoevan added this to the 0.67.0 milestone Jul 17, 2018
@tassoevan tassoevan self-assigned this Jul 17, 2018
@tassoevan tassoevan requested review from ggazzo and sampaiodiego July 17, 2018 17:28
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11486 July 17, 2018 17:29 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11486 July 17, 2018 22:02 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11486 July 18, 2018 05:07 Inactive
@tassoevan tassoevan changed the title [WIP] [IMPROVE] [FIX] Room uploaded files gallery fixes and search form [IMPROVE] [FIX] Room uploaded files gallery fixes and search form Jul 18, 2018
<a href="{{fixCordova url}}" title="{{name}}" data-description="{{description}}" rel="noopener noreferrer" target="_blank"
class="attachments__item-link {{fileTypeClass}}">
{{#with thumb}}
<span class="attachments__thumb" style="background-image:url('{{.}}');"></span>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this escape '?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh-oh. I gotta fix it.

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11486 July 18, 2018 16:04 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11486 July 18, 2018 16:36 Inactive
@tassoevan
Copy link
Copy Markdown
Member Author

@MartinSchoeler This PR introduce some new API for back end. Can you document it?

@ggazzo ggazzo requested a deployment to rocket-chat-pr-11486 July 19, 2018 02:42 Abandoned
@ggazzo ggazzo merged commit 0306438 into develop Jul 19, 2018
@ggazzo ggazzo deleted the fix.room-files branch July 19, 2018 02:45
@ggazzo ggazzo changed the title [IMPROVE] [FIX] Room uploaded files gallery fixes and search form [INEW] Room files search form Jul 19, 2018
@ggazzo ggazzo changed the title [INEW] Room files search form [NEW] Room files search form Jul 19, 2018
@theorenck theorenck modified the milestones: 0.67.0, 0.68.0 Jul 19, 2018
@sampaiodiego sampaiodiego mentioned this pull request Jul 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ui/ux Related to UI/UX, frontend code, accessibility, and user interaction type: bug type: improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants