Skip to content

[FIX] Fix and improve Atlassian Crowd User Sync#11483

Closed
kos4live wants to merge 8 commits intoRocketChat:developfrom
kos4live:fix-crowd-sync
Closed

[FIX] Fix and improve Atlassian Crowd User Sync#11483
kos4live wants to merge 8 commits intoRocketChat:developfrom
kos4live:fix-crowd-sync

Conversation

@kos4live
Copy link
Copy Markdown
Contributor

@kos4live kos4live commented Jul 17, 2018

Before the sync was running into a exception of "Cannot read property 'crowdClient' of undefined" and was running on all instances redundant.
Now the described issue was fixed and used SyncedCron with configurable sync interval.

@RocketChat RocketChat deleted a comment Jul 18, 2018
@RocketChat RocketChat deleted a comment Jul 18, 2018
@RocketChat RocketChat deleted a comment Jul 18, 2018
@RocketChat RocketChat deleted a comment Jul 18, 2018
@RocketChat RocketChat deleted a comment Jul 18, 2018
@RocketChat RocketChat deleted a comment Jul 18, 2018
@kos4live kos4live mentioned this pull request Jul 18, 2018
Closed
@piotrkochan
Copy link
Copy Markdown
Contributor

piotrkochan commented Sep 3, 2018

could you get rid of this plain password saved in user document?

@piotrkochan
Copy link
Copy Markdown
Contributor

piotrkochan commented Sep 3, 2018

Maybe it is good idea to merge these changes with https://gist.github.com/jsternadel/09d2a068343f64146e98f675b20666e7 together?

@engelgabriel engelgabriel added this to the 0.74.0 milestone Feb 15, 2019
@engelgabriel engelgabriel mentioned this pull request Feb 15, 2019
Merged
@steerben
Copy link
Copy Markdown
Contributor

steerben commented Feb 15, 2019

Nice to see, that it progresses @engelgabriel

@Hudell
Copy link
Copy Markdown
Contributor

Hudell commented Feb 18, 2019

It seems like a good part of this pull request is already implemented on our develop branch now. @kos4live I'm sorry it took us so long to check this, but do you mind comparing your changes to the ones that were merged and check if there's anything missing?

@engelgabriel engelgabriel modified the milestones: 0.74.0, 1.0.0 Feb 22, 2019
@rodrigok
Copy link
Copy Markdown
Member

rodrigok commented Mar 2, 2019

@Hudell can you check what is different from our new changes and see if it makes sense?

@engelgabriel engelgabriel modified the milestones: 1.0.0, 1.1.0 Apr 29, 2019
@rodrigok
Copy link
Copy Markdown
Member

rodrigok commented May 15, 2019

@Hudell ping, can you check this?

@rodrigok rodrigok modified the milestones: 1.1.0, 1.2.0 May 15, 2019
@Hudell
Copy link
Copy Markdown
Contributor

Hudell commented May 15, 2019

I compared the PR with the existing implementation and with the only exception of a try catch being handled in a different place, it's pretty much the same code.

I'll be closing this one now.

@Hudell Hudell closed this May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rodrigok rodrigok Awaiting requested review from rodrigok

@sampaiodiego sampaiodiego Awaiting requested review from sampaiodiego

Assignees

@Hudell Hudell

Labels

None yet

Projects

None yet

Milestone

1.2.0

Development

Successfully merging this pull request may close these issues.

6 participants

@kos4live @piotrkochan @steerben @Hudell @rodrigok @engelgabriel