[FIX] Fixed svg for older chrome browsers bug #11414#11416
Merged
ggazzo merged 7 commits intoRocketChat:developfrom Jul 17, 2018
Merged
[FIX] Fixed svg for older chrome browsers bug #11414#11416ggazzo merged 7 commits intoRocketChat:developfrom
ggazzo merged 7 commits intoRocketChat:developfrom
Conversation
|
|
tassoevan
reviewed
Jul 10, 2018
| RocketChat.settings.collection.find({_id:/theme-color-rc/i}, {fields:{ value: 1 }}).observe({changed: () => { DynamicCss.run(true); }}); | ||
|
|
||
| this.isFirefox = navigator.userAgent.match(/Firefox\/(\d+)\.\d/); | ||
| this.isFirefox = navigator.userAgent.match(/(Firefox|Chrome)\/(\d+)\.\d/); |
Member
There was a problem hiding this comment.
For clarity, it's better to keep the original statement and add a new one assigning to this.isChrome.
|
|
||
| Template.icon.helpers({ | ||
| baseUrl: isFirefox && isFirefox[1] < 55 ? firefoxBaseUrlFix : undefined | ||
| baseUrl: isFirefox && isFirefox[2] < 55 ? firefoxBaseUrlFix : undefined |
Member
There was a problem hiding this comment.
Is it the same version number for both browsers?
Contributor
|
I agree with @tassoevan you should create another check for chrome. |
Contributor
Author
|
@karlprieb Changed to a separate check for chrome |
tassoevan
approved these changes
Jul 11, 2018
tassoevan
added
type: bug
area: ui/ux
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11414
Took the Pull Request #9311 and changed the two lines, so that they also apply for Google Chrome.