Skip to content

[FIX] Message attachment's fields with different sizes#11342

Merged
ggazzo merged 1 commit intodevelopfrom
fix-attachment-fields-with-different-sizes
Jul 5, 2018
Merged

[FIX] Message attachment's fields with different sizes#11342
ggazzo merged 1 commit intodevelopfrom
fix-attachment-fields-with-different-sizes

Conversation

@sampaiodiego
Copy link
Copy Markdown
Member

@sampaiodiego sampaiodiego commented Jul 4, 2018

Before:
image

After:
image

Msg schema:

{
  "_id": "bQggkDyau77q9obZX",
  "msg": "",
  "attachments": [
    {
      "fields": [
        {
          "title": "Small field",
          "value": "one line",
          "short": true
        },
        {
          "title": "Big field",
          "value": "multiple\nlines\nsee?",
          "short": true
        }
      ]
    }
  ],
  "bot": {
    "i": "EivbwgSN3eqWkENFw"
  },
  "groupable": false,
  "emoji": ":bug:",
  "ts": "2018-07-04T16:55:04.361Z",
  "u": {
    "_id": "rocket.cat",
    "username": "rocket.cat",
    "name": "Rocket.Cat"
  },
  "rid": "GENERAL",
  "_updatedAt": "2018-07-04T16:55:04.367Z"
}

Copy link
Copy Markdown
Contributor

@vynmera vynmera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed this a while ago, actually. Good to see it fixed :)

@ggazzo ggazzo added the area: ui/ux Related to UI/UX, frontend code, accessibility, and user interaction label Jul 5, 2018
@ggazzo ggazzo added this to the 0.67.0 milestone Jul 5, 2018
@ggazzo ggazzo merged commit b4e9a2e into develop Jul 5, 2018
@ggazzo ggazzo deleted the fix-attachment-fields-with-different-sizes branch July 5, 2018 18:51
@theorenck theorenck modified the milestones: 0.67.0, 0.68.0 Jul 19, 2018
@sampaiodiego sampaiodiego mentioned this pull request Jul 20, 2018
}

& .attachment-fields {
display: flex;
Copy link
Copy Markdown
Contributor

@pandada8 pandada8 Aug 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes all not-short (long?) fields wrap in same row.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it does 😞

@ggazzo will fix this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ui/ux Related to UI/UX, frontend code, accessibility, and user interaction

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants