[NEW] Privacy for custom user fields#11332
Merged
ggazzo merged 2 commits intoRocketChat:developfrom Jul 19, 2018
Merged
Conversation
ggazzo
added
the
area: ui/ux
ggazzo
previously approved these changes
Jul 19, 2018
ggazzo
force-pushed
the
custom-field-privacy
branch
from
363cf82 to
6afaca1
Compare
ggazzo
previously approved these changes
Jul 19, 2018
ggazzo
force-pushed
the
custom-field-privacy
branch
from
6afaca1 to
19507af
Compare
ggazzo
approved these changes
Jul 19, 2018
Merged
Contributor
|
Just a question: can I hide "Created at" and "Last login" with your patch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #6515.
Recreation of #10891 as that PR got rather messy.
Closes #10979
Closes #8070
When using custom user fields, you might not want to expose rather private fields like
statusConnectionor their email. Currently, to view custom fields, theview-full-other-user-infopermission is required.This PR adds an optional
publicfield to allAccounts_CustomFieldsentries, which overrides this requirement, so users without the permission can see the field.Setup
The
publicfield will default to false when not specified.Preview
Any user can see all of their own fields.
However, if they do not have the
view-full-other-user-infopermission, they can only see others' public fields.Of course, those with the
view-full-other-user-infopermission can always see all fields.