Skip to content

[NEW] Setting to disable 2FA globally#11328

Merged
sampaiodiego merged 7 commits intodevelopfrom
setting.disable-2fa
Jul 21, 2018
Merged

[NEW] Setting to disable 2FA globally#11328
sampaiodiego merged 7 commits intodevelopfrom
setting.disable-2fa

Conversation

@Hudell
Copy link
Copy Markdown
Contributor

@Hudell Hudell commented Jul 3, 2018

Closes #7100

@Hudell Hudell added this to the 0.67.0 milestone Jul 3, 2018
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11328 July 3, 2018 21:23 Inactive
@Hudell Hudell changed the title Added a new setting to disable 2fa globally [NEW] Setting to disable 2fa globally Jul 3, 2018
@kaiiiiiiiii
Copy link
Copy Markdown
Contributor

Closes #11106 as well.

@Hudell
Copy link
Copy Markdown
Contributor Author

Hudell commented Jul 6, 2018

Hm, now I wonder if it wouldn't be better to have a permission for this instead of a setting.

@tpDBL
Copy link
Copy Markdown
Contributor

tpDBL commented Jul 10, 2018

+1

@MartinSchoeler
Copy link
Copy Markdown
Member

MartinSchoeler commented Jul 12, 2018

@Hudell If is decided that this setting should be a permission, please don't for get to add it to the Permissions Article in our documentation. Thanks!

@Hudell
Copy link
Copy Markdown
Contributor Author

Hudell commented Jul 12, 2018

It will be a setting for now, as settings are easier to use, but a permission may be added later for more control.

@theorenck theorenck modified the milestones: 0.67.0, 0.68.0 Jul 19, 2018
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11328 July 21, 2018 01:32 Inactive
@sampaiodiego sampaiodiego temporarily deployed to rocket-chat-pr-11328 July 21, 2018 02:20 Inactive
@sampaiodiego sampaiodiego temporarily deployed to rocket-chat-pr-11328 July 21, 2018 02:47 Inactive
@sampaiodiego sampaiodiego changed the title [NEW] Setting to disable 2fa globally [NEW] Setting to disable 2FA globally Jul 21, 2018
@sampaiodiego sampaiodiego merged commit 7f7690d into develop Jul 21, 2018
@sampaiodiego sampaiodiego deleted the setting.disable-2fa branch July 21, 2018 05:23
@sampaiodiego sampaiodiego mentioned this pull request Jul 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants