Skip to content

[IMPROVE] Set default max upload size to 100mb#11327

Merged
ggazzo merged 2 commits intoRocketChat:developfrom
cardoso:patch-5
Jul 20, 2018
Merged

[IMPROVE] Set default max upload size to 100mb#11327
ggazzo merged 2 commits intoRocketChat:developfrom
cardoso:patch-5

Conversation

@cardoso
Copy link
Copy Markdown
Member

@cardoso cardoso commented Jul 3, 2018

The current default experience (2mb max upload size) is confusing for users of other chat platforms. (eg. Slack allows 1gb uploads in their free plan)

Rationale for 100mb is 1 min video output from iPhone X

The current default experience (2mb max upload size) is confusing for users of other chat platforms. (eg. Slack allows 1gb uploads in their free plan)
Copy link
Copy Markdown
Contributor

@vynmera vynmera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about people running Rocket.Chat on a smaller server? This seems like a horrible idea for all servers that don't use special hosting like Slack... abuse should be kept in mind here :(

@cardoso
Copy link
Copy Markdown
Member Author

cardoso commented Jul 3, 2018

@vynmera I think we should aim to have settings as permissive as reasonable by default, so no one feels like something is lacking, and if they wish to have more restrictions, then they can look for the settings.

A change that would solve the problem even further is to make this setting part of the Setup Wizard (custom setup step?) to make it more visible for admins who wish for a more restrictive value.

@vynmera
Copy link
Copy Markdown
Contributor

vynmera commented Jul 3, 2018

I'd say at least keep it to a somewhat sane rate though (like 50MB), but maybe adding an optional "Further setup" wizard to set up all these sorts of settings is a good idea.

@kaiiiiiiiii
Copy link
Copy Markdown
Contributor

This setting should definitely be included in the setup wizard :)

And as @vynmera said, 1GB as a default value seems to be a bit too much. 50MB sounds a lot better (:

@cardoso
Copy link
Copy Markdown
Member Author

cardoso commented Jul 3, 2018

I'd say 100mb minimum, as that's a common 1 min video output from an iPhone

@cardoso cardoso changed the title [IMPROVEMENT] Set default max upload size to 1gb [IMPROVEMENT] Set default max upload size to 100mb Jul 13, 2018
@geekgonecrazy
Copy link
Copy Markdown
Contributor

@RocketChat/core can we get eyes? :)

@rodrigok rodrigok added this to the 0.67.0 milestone Jul 19, 2018
@rodrigok rodrigok changed the title [IMPROVEMENT] Set default max upload size to 100mb [IMPROVE] Set default max upload size to 100mb Jul 19, 2018
@ggazzo ggazzo modified the milestones: 0.67.0, 0.68.0 Jul 20, 2018
@ggazzo ggazzo merged commit 5244bd5 into RocketChat:develop Jul 20, 2018
@sampaiodiego sampaiodiego mentioned this pull request Jul 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants