[FIX] Remove title attribute from sidebar items#11298
Conversation
tassoevan
added
type: bug
area: ui/ux
tassoevan
force-pushed
the
fix.room-list-items-title
branch
from
8777e56 to
691a447
Compare
vynmera
left a comment
vynmera
left a comment
There was a problem hiding this comment.
The tests need to be updated, they expect an element with the title attribute. Perhaps we can use a data attribute (data-name or w/e) instead, if the tests have to be done on an attribute.
|
IMHO we should keep the title with the channel name because this is the only way to read long channel names without entering them. I'll reply to the issue as well. |
This reverts commit 691a447.
|
@sampaiodiego While I agree with that usage of the title attribute, using the default system tooltip for that is pointless without a mouse: keyboard and touch interactions don't benefit that much from it. Maybe expand the element on hover/long press touch to not add a text ellipsis works better. |
|
Maybe add title attribute over demand? |
|
@tassoevan I really liked your implementation. |
|
@karlprieb No tooltips in mobile browsers at all.
I tried to implement the same custom tooltips used in the sidebar header buttons, but they doesn't work in mobile too. I also tried to expand the sidebar item as PoC, but the required effort was bigger than I expected due to I noticed that many texts are ellipsed in mobile and you need a lot of taps to see their content. Specifically talking about channel names, even in a room you don't have a option to completely see its name without opening "Room Info". My fix just contemplates desktop users for now and I think we need to understand what would be better from the users. |
vynmera
left a comment
vynmera
left a comment
There was a problem hiding this comment.
Thank you for your fixes :)
| 'click [data-id], click .sidebar-item__link'() { | ||
| return menu.close(); | ||
| }, | ||
| 'mouseover .sidebar-item__link'(e) { |
There was a problem hiding this comment.
should the mouseenter event be used? since it needs to be checked only once
7 participants
Closes #4440
@graywolf336 suggested to keep the attribute but replace its value with room
topicordescription; however, the sidebar renders items fromsubscriptionscollection, notrooms, therefore there is no easy way to implement it without break things server-side.