[FIX] Livestream muted when audio only option was enabled#11267
Merged
sampaiodiego merged 3 commits intodevelopfrom Jul 3, 2018
Merged
[FIX] Livestream muted when audio only option was enabled#11267sampaiodiego merged 3 commits intodevelopfrom
sampaiodiego merged 3 commits intodevelopfrom
Conversation
gdelavald
added
the
area: ui/ux
ggazzo
approved these changes
Jun 26, 2018
karlprieb
approved these changes
Jun 27, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to a new flag on Chrome, when the video player was hidden (or open in another tab) it would not start automatically, this was causing a bug when audio only mode was enabled for the popout window on the Livestream feature.
The fix simply remove the visibility hidden and forces a 0px on the player height with overflow being hidden, it looks the same as before but the video is not considered hidden anymore.