Skip to content

Regression: Directory css#11206

Merged
rodrigok merged 8 commits intodevelopfrom
fix-table-css
Jun 21, 2018
Merged

Regression: Directory css#11206
rodrigok merged 8 commits intodevelopfrom
fix-table-css

Conversation

@ggazzo
Copy link
Copy Markdown
Member

@ggazzo ggazzo commented Jun 21, 2018

before:

image

after

image

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11206 June 21, 2018 00:27 Inactive
@ggazzo ggazzo temporarily deployed to rocket-chat-pr-11206 June 21, 2018 00:55 Inactive
@ggazzo ggazzo added this to the 0.66.0 milestone Jun 21, 2018
@ggazzo ggazzo added the area: ui/ux Related to UI/UX, frontend code, accessibility, and user interaction label Jun 21, 2018
rodrigok
rodrigok previously approved these changes Jun 21, 2018
font-weight: 400;
font-weight: 500;
line-height: 1rem;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add display: inline-block and vertical-align: middle for all children elements of table-fake-th to align them vertically

@ggazzo ggazzo dismissed karlprieb’s stale review June 21, 2018 01:19

he doesn't know nothing about css :)

@rodrigok rodrigok merged commit ee86332 into develop Jun 21, 2018
@rodrigok rodrigok deleted the fix-table-css branch June 21, 2018 01:54
@rodrigok rodrigok mentioned this pull request Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ui/ux Related to UI/UX, frontend code, accessibility, and user interaction

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants