[FIX] Custom sound uploader not working in Firefox and IE#11139
Merged
engelgabriel merged 1 commit intoRocketChat:developfrom Aug 13, 2018
Merged
[FIX] Custom sound uploader not working in Firefox and IE#11139engelgabriel merged 1 commit intoRocketChat:developfrom
engelgabriel merged 1 commit intoRocketChat:developfrom
Conversation
vynmera
changed the title
This was referenced Jul 7, 2018
engelgabriel
approved these changes
Aug 13, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8460
Actually closes #6200
A fix that was made before only fixed half of the issue, sadly.
Now it is fully fixed and happy, and you can silently change your coworker's notification sound to the loudest version of the Monopoly theme you can find on the internet, all from Firefox.
Oh yeah, Firefox wasn't showing the file picker properly either, it let you select non-mp3 files. So that's fixed too, in case you find yourself confusing .mp3 and .png far too often. :-)
Before:
After:
