Skip to content

Add Dockerfile with MongoDB#10971

Merged
rodrigok merged 9 commits intodevelopfrom
docker-mongo
Jun 27, 2018
Merged

Add Dockerfile with MongoDB#10971
rodrigok merged 9 commits intodevelopfrom
docker-mongo

Conversation

@rodrigok
Copy link
Copy Markdown
Member

@rodrigok rodrigok commented Jun 1, 2018

This will generate a new Docker image, in addition to the existent ones, for preview and tests purposes.

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-10971 June 1, 2018 18:07 Inactive
@geekgonecrazy
Copy link
Copy Markdown
Contributor

geekgonecrazy commented Jun 1, 2018

Are we sure we want to do this? I think this will be a support nightmare. Not to mention hurting the docker purist in me so very badly. Multiple processes in a docker container kind of defeats the whole purpose of docker and containerization.

[edit] Now I get the purposed. Testing... and a way to quickly bring up and preview

@@ -0,0 +1,10 @@
#!/bin/bash

mongod --fork --config /etc/mongod.conf
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even though not meant for production and only preview... Maybe we should add: --smallfiles --storageEngine=mmapv1

For sure I think the storageEngine bit.

@toughIQ
Copy link
Copy Markdown

toughIQ commented Jun 1, 2018

I am also more the „one container, one process“ guy. What does the addition of mongo solve or improve? I would stick with the docker-compose way of combining Rocket.Chat and mongo containers.

@geekgonecrazy
Copy link
Copy Markdown
Contributor

I just edited my reply. But talked a bit, the goal is for quick and easy way to preview Rocket.Chat on-premises. Also for use in testing. For sure not an alternative way to run a production system.

@engelgabriel
Copy link
Copy Markdown
Member

Can we add a README.MD and a BIG comment on the docker file that this is for preview and automated testing only, and not meant for production environments?

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-10971 June 2, 2018 14:48 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-10971 June 2, 2018 14:50 Inactive
@geekgonecrazy
Copy link
Copy Markdown
Contributor

Yes this would help a ton! I wonder if we want to make it super easy... Should we go so far as to set it up with a user so they just login and start using? Helping re-inforce(hopefully) that it's a preview?

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-10971 June 4, 2018 05:52 Inactive
@JSzaszvari
Copy link
Copy Markdown
Contributor

JSzaszvari commented Jun 7, 2018

@engelgabriel is on the money here.

There really needs to be a large warning everywhere possible that this is for previewing and not production.

Might be worth putting this in the container as a start up banner similar to what I've done for the rocket.chat hubot container

banner

@geekgonecrazy
Copy link
Copy Markdown
Contributor

geekgonecrazy commented Jun 7, 2018

Ooooh! We already have a bash script included. Would be awesome to have ascii text saying something like:

Rocket.Chat Preview(in sweet ascii text)

This image is for testing purposes only. Please do not attempt to use in production. For deploying a production ready install please see: https://rocket.chat/docs/installation/

@engelgabriel
Copy link
Copy Markdown
Member

@geekgonecrazy can you add this sweet ascii text to .docker-mongo/entrypoint.sh?

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-10971 June 12, 2018 13:09 Inactive
@engelgabriel engelgabriel added this to the 0.66.0 milestone Jun 12, 2018
@rodrigok
Copy link
Copy Markdown
Member Author

We need to define if this will be a tag like rocketchat:0.61.0-preview or if this will be another image (I prefer this) like rocketchat-preview:0.61.0

@geekgonecrazy
Copy link
Copy Markdown
Contributor

@JSzaszvari what did you use to generate that text for hubot?

@rodrigok I agree. It should be a completely separate image. Treat it as completely separate thing so it's always clear it's not production with every little detail 😁

@engelgabriel
Copy link
Copy Markdown
Member

I agree with @geekgonecrazy , it should be a completely separate image

@sampaiodiego sampaiodiego temporarily deployed to rocket-chat-pr-10971 June 26, 2018 20:00 Inactive
@sampaiodiego
Copy link
Copy Markdown
Member

As per suggestions, I've added the Rocket.Chat Preview banner.

I've also included the new docker image on CI as rocket.chat.preview .. it will have the same tags as the official one

@sampaiodiego sampaiodiego temporarily deployed to rocket-chat-pr-10971 June 26, 2018 20:33 Inactive
@sampaiodiego sampaiodiego temporarily deployed to rocket-chat-pr-10971 June 26, 2018 21:31 Inactive
@sampaiodiego sampaiodiego temporarily deployed to rocket-chat-pr-10971 June 26, 2018 22:05 Inactive
@sampaiodiego sampaiodiego temporarily deployed to rocket-chat-pr-10971 June 26, 2018 22:16 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants