[FIX] Dropdown elements were using old styles#10482
Merged
rodrigok merged 4 commits intoRocketChat:developfrom Apr 19, 2018
kaiiiiiiiii:fix_selector_element_type_for_dropdowns
Merged
[FIX] Dropdown elements were using old styles#10482rodrigok merged 4 commits intoRocketChat:developfrom kaiiiiiiiii:fix_selector_element_type_for_dropdowns
rodrigok merged 4 commits intoRocketChat:developfrom
kaiiiiiiiii:fix_selector_element_type_for_dropdowns
Conversation
kaiiiiiiiii
changed the title
kaiiiiiiiii
changed the title
Contributor
|
@kaiiiiiiiii can you add this arrow icon like we did on the RocketChat Apps admin panel? Thank you! 👍 |
Contributor
Author
|
@karlprieb Done :) |
Contributor
|
Thank you @kaiiiiiiiii :) Can you add a screenshot about the cut off at the bottom that all select elements have? |
Contributor
Author
|
100% zoom 400% zoom 1600% zoom The UI gets a bit messy with zoom, but it's really hard to see the cut off without it. |
Contributor
|
@kaiiiiiiiii you can put |
Contributor
Author
|
Done that as well, mate :) |
karlprieb
approved these changes
Apr 19, 2018
karlprieb
added
the
area: ui/ux
rodrigok
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes my promise to @karlprieb.
This PR changes all dropdown element types from rc-input__element to rc-select__element.
Two more things:
Before (User UI):
After (User UI):
Before (Admin UI):
After (Admin UI):
