[NEW] Setting option to mark as containing a secret/password#10273
Merged
rodrigok merged 6 commits intoRocketChat:developfrom May 20, 2019
Merged
[NEW] Setting option to mark as containing a secret/password#10273rodrigok merged 6 commits intoRocketChat:developfrom
rodrigok merged 6 commits intoRocketChat:developfrom
Conversation
Contributor
|
Let's move this to the next release, just because it's not needed at this point in time for the Apps. But will be needed next release. Thanks for making this @kb0304! |
Hudell
previously approved these changes
Aug 14, 2018
Member
sampaiodiego
previously requested changes
Sep 11, 2018
Member
sampaiodiego
left a comment
sampaiodiego
left a comment
There was a problem hiding this comment.
I have found few settings missing the secret option.
Looks like the following LDAP settings were renamed but wasn't added as secret:
- LDAP_Authentication_UserDN is the new one for the
LDAP_Domain_Search_User - LDAP_Authentication_Password is the new one for the
LDAP_Domain_Search_Password
And following settings seems to be new: FileUpload_Webdav_Password is missing the secret
Co-authored-by: kb0304 <[email protected]> Co-authored-by: Aaron Ogle <[email protected]>
geekgonecrazy
force-pushed
the
setting_secret
branch
from
b432542 to
431e629
Compare
Contributor
|
wow git is painful... but its now up to date. 😌 @sampaiodiego |
Member
Contributor
|
@sampaiodiego fixed! Some how that got lost during all of the git shuffle 😢 |
sampaiodiego
previously approved these changes
Apr 6, 2019
Member
|
Can someone fix the conflicts? |
Member
|
Missing following settings as secret:
|
rodrigok
approved these changes
May 20, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #9790