[NEW] Slackbridge: send attachment notifications#10269
Merged
sampaiodiego merged 40 commits intoRocketChat:developfrom Aug 21, 2018
Merged
[NEW] Slackbridge: send attachment notifications#10269sampaiodiego merged 40 commits intoRocketChat:developfrom
sampaiodiego merged 40 commits intoRocketChat:developfrom
Conversation
Introduced ES2015 Import/Export to resolve dependencies
…at into dynamic-groups
…at into slackbridge-attachments
Member
|
@Hudell can you fix the conflict? |
…at into slackbridge-attachments
rodrigok
reviewed
Jun 20, 2018
| logger.class.debug(`Setting: ${ key }`, value); | ||
| }); | ||
|
|
||
| //Import messages from Slack with an alias; %s is replaced by the username of the user. If empty, no alias will be used. |
Member
There was a problem hiding this comment.
Does this makes part of this PR?
rodrigok
reviewed
Jun 20, 2018
|
|
||
| //Hack to notify that a file was attempted to be uploaded | ||
| delete slackMessage.subtype; | ||
| slackMessage.text = `Uploaded a file: ${ slackMessage.file.permalink }`; |
Member
There was a problem hiding this comment.
Could we post this as an attachment to have the preview and remove that, not translated, text?
rodrigok
reviewed
Jun 20, 2018
| file_name = Meteor.absoluteUrl(title_link); | ||
| } | ||
|
|
||
| const message = `Uploaded a file: ${ file_name }`; |
Member
There was a problem hiding this comment.
Any idea of how to not have that text? Have a fixed text in english seems wrong.
rodrigok
previously approved these changes
Aug 20, 2018
sampaiodiego
approved these changes
Aug 21, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes an item on #8012 , merging PR #6309
Original Description: