[NEW] Setting to enable/disable slack bridge reactions#10217
Merged
sampaiodiego merged 35 commits intoRocketChat:developfrom Aug 20, 2018
Merged
[NEW] Setting to enable/disable slack bridge reactions#10217sampaiodiego merged 35 commits intoRocketChat:developfrom
sampaiodiego merged 35 commits intoRocketChat:developfrom
Conversation
Introduced ES2015 Import/Export to resolve dependencies
…at into dynamic-groups
…at into slackbridge-reactions
Member
|
@Hudell can you fix the conflict? |
rodrigok
reviewed
Jun 20, 2018
| this.slack.setRocket(this.rocket); | ||
|
|
||
| //Settings that we cache versus looking up at runtime | ||
| this.apiToken = {}; |
Member
There was a problem hiding this comment.
Why are you defining the default values as objects?
| api.addFiles('server/RocketAdapter.js', 'server'); | ||
| api.addFiles('server/SlackAdapter.js', 'server'); | ||
|
|
||
| api.addFiles('server/slackbridge_import.server.js', 'server'); |
Member
There was a problem hiding this comment.
Why are you including this file?
rodrigok
reviewed
Aug 20, 2018
| this.apiToken = false; | ||
| this.aliasFormat = {}; | ||
| this.excludeBotnames = {}; | ||
| this.isReactionsEnabled = {}; |
Member
There was a problem hiding this comment.
Why these 3 items are object by default?
rodrigok
reviewed
Aug 20, 2018
| i18nDescription: 'Exclude_Botnames_Description', | ||
| }); | ||
|
|
||
| this.add('SlackBridge_Reactions_Enabled', false, { |
Member
There was a problem hiding this comment.
Should we change the behavior to be disabled by default?
rodrigok
approved these changes
Aug 20, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes an item on #8012 , merging PR #6285
Also closes #6044.
Original description: