[HOTFIX][MASTER] SAML repair#10209
Closed
arminfelder wants to merge 3 commits intoRocketChat:masterfrom
Closed
Conversation
This was referenced Mar 24, 2018
Closed
This was referenced Mar 24, 2018
Contributor
|
Thanks for opening this series of PR's We are about to be cutting our next release candidate and then 7 days later actually releasing 0.63.0. So because of that i'm going to go ahead and close this in favor of #10210 if we do decide to cut a hotfix we can cherry pick the commit. Thanks for the extra effort here! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hotfix to repair the SAML functionality, by updating the SAML package code
fixes #10056
same as:
#10212 -> fix for release candidate
#10210 -> fix for develop
#10209 -> fix for master