[NEW] Livechat setting to customize ended conversation message#10108
[NEW] Livechat setting to customize ended conversation message#10108sampaiodiego merged 3 commits intodevelopfrom
Conversation
sampaiodiego
left a comment
sampaiodiego
left a comment
There was a problem hiding this comment.
only small changes.. overall looks good
| type: 'string', | ||
| group: 'Livechat', | ||
| public: true, | ||
| section: 'Conversation Finished', |
There was a problem hiding this comment.
I don't think this setting should be on a new Section, it can be confusing (there are other settings that might fit here) and I don't see a reason for a section with only one setting. so I would rather put it bellow Show agent email agent email setting 😉
There was a problem hiding this comment.
Yes, you're totally right.
I made a mistake, to be honest I'm surprise reviewing this code.
Fixed.
| </div> | ||
| </fieldset> | ||
| <fieldset> | ||
| <legend>{{_ "Conversation_finished"}}</legend> |
There was a problem hiding this comment.
There was a problem hiding this comment.
🤦♂️ my global search excludes i18n JSON files. sry 😬
the test instance I used also didn't have this translation 🤷♂️
| return t('Welcome', { user: this.u.username }); | ||
| case 'livechat-close': | ||
| return t('Conversation_finished'); | ||
| return (!_.isEmpty(Livechat.conversationFinishedMessage)) ? Livechat.conversationFinishedMessage : t('Conversation_finished'); |
There was a problem hiding this comment.
if possible I would try to not use underscore =)
sampaiodiego
changed the title
sampaiodiego
changed the title
sampaiodiego
deleted the
livechat-customization-of-the-conversation-finished
branch
4 participants
@RocketChat/core
Closes #9873
This PR allows to customize the message that will be displayed at the end of the conversation in LiveChat widget.