[NEW] search only default tone emoji Popup search#10017
Conversation
…c after emoji with tones
ggazzo
previously approved these changes
Jul 19, 2018
ggazzo
approved these changes
Jul 19, 2018
ggazzo
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #9898
Currently the pop up emoji search can get clogged with tonal versions of the same emoji
In this PR i propose to exclude Tonal versions of emojis from popUp until the user begins to explicitly request them
This code will hides tones as shown above until the user begins typing _t (and keeps them shown through typing _tone[1-5]: as below
While not the suggested fix, perhaps this functionality is true to the intent, this way one retains full emoji power and a more powerful search, without taking the hands off the keyboard.