Skip to content

Incoming webhook to non-existent channel doesn't raise an error #8476

@antgel

Description

@antgel

See the log below. There's no error in the room to say the channel doesn't exist. Caller gets back a 400 Bad Response.

rocketchat_1 | Integrations ➔ Incoming WebHook.info Post integration: TFS Work Item Commented On
rocketchat_1 | Integrations ➔ Incoming WebHook.debug @urlParams: { integrationId: '38xQ9ZR6aqSR5aKry',
rocketchat_1 |   token: 'cjkqy6isCJsiQqsjypyD4n54aDH6Z6hGm8Hvojes3ZZc8HJE' }
rocketchat_1 | Integrations ➔ Incoming WebHook.debug @bodyParams: { subscriptionId: '5bc666d5-ba40-457c-9be7-f1a8c2259d54',
rocketchat_1 |   notificationId: 28,
rocketchat_1 |   id: 'fb2617ed-60df-4518-81fa-749faa6c5cd6',
rocketchat_1 |   eventType: 'workitem.commented',
rocketchat_1 |   publisherId: 'tfs',
rocketchat_1 |   message:
rocketchat_1 |    { text: 'Bug #5 (Some great new idea!) commented on by Jamal Hartnett.\r\n(http://fabrikam-fiber-inc.visualstudio.com/web/wi.aspx?pcguid=74e918bf-3376-436d-bd20-8e8c1287f465&id=5)',
rocketchat_1 |      html: '<a href="http://fabrikam-fiber-inc.visualstudio.com/web/wi.aspx?pcguid=74e918bf-3376-436d-bd20-8e8c1287f465&amp;id=5">Bug #5</a> (Some great new idea!) commented on by Jamal Hartnett.',
rocketchat_1 |      markdown: '[Bug #5](http://fabrikam-fiber-inc.visualstudio.com/web/wi.aspx?pcguid=74e918bf-3376-436d-bd20-8e8c1287f465&id=5) (Some great new idea!) commented on by Jamal Hartnett.' },
rocketchat_1 |   detailedMessage:
rocketchat_1 |    { text: 'Bug #5 (Some great new idea!) commented on by Jamal Hartnett.\r\n(http://fabrikam-fiber-inc.visualstudio.com/web/wi.aspx?pcguid=74e918bf-3376-436d-bd20-8e8c1287f465&id=5)\r\nThis is a great new idea',
rocketchat_1 |      html: '<a href="http://fabrikam-fiber-inc.visualstudio.com/web/wi.aspx?pcguid=74e918bf-3376-436d-bd20-8e8c1287f465&amp;id=5">Bug #5</a> (Some great new idea!) commented on by Jamal Hartnett.<br/>This is a great new idea',
rocketchat_1 |      markdown: '[Bug #5](http://fabrikam-fiber-inc.visualstudio.com/web/wi.aspx?pcguid=74e918bf-3376-436d-bd20-8e8c1287f465&id=5) (Some great new idea!) commented on by Jamal Hartnett.\r\nThis is a great new idea' },
rocketchat_1 |   resource:
rocketchat_1 |    { id: 5,
rocketchat_1 |      rev: 4,
rocketchat_1 |      fields:
rocketchat_1 |       { 'System.AreaPath': 'FabrikamCloud',
rocketchat_1 |         'System.TeamProject': 'FabrikamCloud',
rocketchat_1 |         'System.IterationPath': 'FabrikamCloud\\Release 1\\Sprint 1',
rocketchat_1 |         'System.WorkItemType': 'Bug',
rocketchat_1 |         'System.State': 'New',
rocketchat_1 |         'System.Reason': 'New defect reported',
rocketchat_1 |         'System.CreatedDate': '2014-07-15T17:42:44.663Z',
rocketchat_1 |         'System.CreatedBy': 'Jamal Hartnett',
rocketchat_1 |         'System.ChangedDate': '2014-07-15T17:42:44.663Z',
rocketchat_1 |         'System.ChangedBy': 'Jamal Hartnett',
rocketchat_1 |         'System.Title': 'Some great new idea!',
rocketchat_1 |         'Microsoft.VSTS.Common.Severity': '3 - Medium',
rocketchat_1 |         'WEF_EB329F44FE5F4A94ACB1DA153FDF38BA_Kanban.Column': 'New',
rocketchat_1 |         'System.History': 'This is a great new idea' },
rocketchat_1 |      _links:
rocketchat_1 |       { self: [Object],
rocketchat_1 |         workItemUpdates: [Object],
rocketchat_1 |         workItemRevisions: [Object],
rocketchat_1 |         workItemType: [Object],
rocketchat_1 |         fields: [Object] },
rocketchat_1 |      url: 'http://fabrikam-fiber-inc.visualstudio.com/DefaultCollection/_apis/wit/workItems/5' },
rocketchat_1 |   resourceVersion: '1.0',
rocketchat_1 |   resourceContainers:
rocketchat_1 |    { collection: { id: 'c12d0eb8-e382-443b-9f9c-c52cba5014c2' },
rocketchat_1 |      account: { id: 'f844ec47-a9db-4511-8281-8b63f4eaf94e' },
rocketchat_1 |      project: { id: 'be9b3917-87e6-42a4-a549-2bc06a7a878f' } },
rocketchat_1 |   createdDate: '2017-10-13T11:29:36.4864356Z' }
rocketchat_1 | { subscriptionId: '5bc666d5-ba40-457c-9be7-f1a8c2259d54',
rocketchat_1 |   notificationId: 28,
rocketchat_1 |   id: 'fb2617ed-60df-4518-81fa-749faa6c5cd6',
rocketchat_1 |   eventType: 'workitem.commented',
rocketchat_1 |   publisherId: 'tfs',
rocketchat_1 |   message:
rocketchat_1 |    { text: 'Bug #5 (Some great new idea!) commented on by Jamal Hartnett.\r\n(http://fabrikam-fiber-inc.visualstudio.com/web/wi.aspx?pcguid=74e918bf-3376-436d-bd20-8e8c1287f465&id=5)',
rocketchat_1 |      html: '<a href="http://fabrikam-fiber-inc.visualstudio.com/web/wi.aspx?pcguid=74e918bf-3376-436d-bd20-8e8c1287f465&amp;id=5">Bug #5</a> (Some great new idea!) commented on by Jamal Hartnett.',
rocketchat_1 |      markdown: '[Bug #5](http://fabrikam-fiber-inc.visualstudio.com/web/wi.aspx?pcguid=74e918bf-3376-436d-bd20-8e8c1287f465&id=5) (Some great new idea!) commented on by Jamal Hartnett.' },
rocketchat_1 |   detailedMessage:
rocketchat_1 |    { text: 'Bug #5 (Some great new idea!) commented on by Jamal Hartnett.\r\n(http://fabrikam-fiber-inc.visualstudio.com/web/wi.aspx?pcguid=74e918bf-3376-436d-bd20-8e8c1287f465&id=5)\r\nThis is a great new idea',
rocketchat_1 |      html: '<a href="http://fabrikam-fiber-inc.visualstudio.com/web/wi.aspx?pcguid=74e918bf-3376-436d-bd20-8e8c1287f465&amp;id=5">Bug #5</a> (Some great new idea!) commented on by Jamal Hartnett.<br/>This is a great new idea',
rocketchat_1 |      markdown: '[Bug #5](http://fabrikam-fiber-inc.visualstudio.com/web/wi.aspx?pcguid=74e918bf-3376-436d-bd20-8e8c1287f465&id=5) (Some great new idea!) commented on by Jamal Hartnett.\r\nThis is a great new idea' },
rocketchat_1 |   resource:
rocketchat_1 |    { id: 5,
rocketchat_1 |      rev: 4,
rocketchat_1 |      fields:
rocketchat_1 |       { 'System.AreaPath': 'FabrikamCloud',
rocketchat_1 |         'System.TeamProject': 'FabrikamCloud',
rocketchat_1 |         'System.IterationPath': 'FabrikamCloud\\Release 1\\Sprint 1',
rocketchat_1 |         'System.WorkItemType': 'Bug',
rocketchat_1 |         'System.State': 'New',
rocketchat_1 |         'System.Reason': 'New defect reported',
rocketchat_1 |         'System.CreatedDate': '2014-07-15T17:42:44.663Z',
rocketchat_1 |         'System.CreatedBy': 'Jamal Hartnett',
rocketchat_1 |         'System.ChangedDate': '2014-07-15T17:42:44.663Z',
rocketchat_1 |         'System.ChangedBy': 'Jamal Hartnett',
rocketchat_1 |         'System.Title': 'Some great new idea!',
rocketchat_1 |         'Microsoft.VSTS.Common.Severity': '3 - Medium',
rocketchat_1 |         'WEF_EB329F44FE5F4A94ACB1DA153FDF38BA_Kanban.Column': 'New',
rocketchat_1 |         'System.History': 'This is a great new idea' },
rocketchat_1 |      _links:
rocketchat_1 |       { self: [Object],
rocketchat_1 |         workItemUpdates: [Object],
rocketchat_1 |         workItemRevisions: [Object],
rocketchat_1 |         workItemType: [Object],
rocketchat_1 |         fields: [Object] },
rocketchat_1 |      url: 'http://fabrikam-fiber-inc.visualstudio.com/DefaultCollection/_apis/wit/workItems/5' },
rocketchat_1 |   resourceVersion: '1.0',
rocketchat_1 |   resourceContainers:
rocketchat_1 |    { collection: { id: 'c12d0eb8-e382-443b-9f9c-c52cba5014c2' },
rocketchat_1 |      account: { id: 'f844ec47-a9db-4511-8281-8b63f4eaf94e' },
rocketchat_1 |      project: { id: 'be9b3917-87e6-42a4-a549-2bc06a7a878f' } },
rocketchat_1 |   createdDate: '2017-10-13T11:29:36.4864356Z' }
rocketchat_1 | Integrations ➔ Incoming WebHook.debug [Process Incoming Request result of Trigger TFS Work Item Commented On :]
rocketchat_1 | Integrations ➔ Incoming WebHook.debug result { attachments:
rocketchat_1 |    [ { title: undefined,
rocketchat_1 |        title_link: 'http://fabrikam-fiber-inc.visualstudio.com/DefaultCollection/_apis/wit/workItems/5',
rocketchat_1 |        text: 'Bug #5 (Some great new idea!) commented on by Jamal Hartnett.\r\n(http://fabrikam-fiber-inc.visualstudio.com/web/wi.aspx?pcguid=74e9

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions