Description:

After upgrading to 4.4.0 apps like /tenor or /giphy no longer return results.

Steps to reproduce:

Issue /giphy, /tenor or /imgur app commands in any room.

Expected behavior:

Show previews for image choice.

Actual behavior:

Following in logs when command is executed:

I20220129-06:45:12.731(-5) Exception while invoking method 'getSlashCommandPreviews' TypeError: Cannot read property 'id' of undefined at Object._executeSlashCommandPreview [as getPreviews] (app/utils/lib/slashCommand.js:34:17) at MethodInvocation.getSlashCommandPreviews (app/lib/server/methods/getSlashCommandPreviews.js:26:24) at MethodInvocation.methodsMap. (app/lib/server/lib/debug.js:74:34) at maybeAuditArgumentChecks (packages/ddp-server/livedata_server.js:1885:12) at packages/ddp-server/livedata_server.js:769:19 at Meteor.EnvironmentVariable.EVp.withValue (packages/meteor.js:1257:12) at packages/ddp-server/livedata_server.js:767:46 at Meteor.EnvironmentVariable.EVp.withValue (packages/meteor.js:1257:12) at packages/ddp-server/livedata_server.js:765:46 at new Promise () at Session.method (packages/ddp-server/livedata_server.js:739:23) at packages/ddp-server/livedata_server.js:603:43

Server Setup Information:

Version
4.4.0
Deployment ID
DEswvvzai9v6M2LwC
Apps Engine Version
1.30.0
Node Version
v14.18.2
Database Migration
253 (January 29, 2022 6:44 AM)
MongoDB
5.0.5 / wiredTiger (oplog Enabled)

I've also noticed that tiny-secp256k1 fails to build with node 14.18.2, it did compile fine with 12.22.1 the node version for the previous version of RocketChat.

Build log:

0 info it worked if it ends with ok
1 verbose cli [
1 verbose cli '/opt/Rocket.Chat/.nvm/versions/node/v14.18.2/bin/node',
1 verbose cli '/opt/Rocket.Chat/.nvm/versions/node/v14.18.2/bin/npm',
1 verbose cli 'run',
1 verbose cli 'build'
1 verbose cli ]
2 info using [email protected]
3 info using [email protected]
4 verbose run-script [ 'prebuild', 'build', 'postbuild' ]
5 info lifecycle [email protected]prebuild: [email protected]
6 info lifecycle [email protected]build: [email protected]
7 verbose lifecycle [email protected]build: unsafe-perm in lifecycle true
8 verbose lifecycle [email protected]build: PATH: /opt/Rocket.Chat/.nvm/versions/node/v14.18.2/lib/node_modules/npm/node_modules/npm-lifecycle/node-gyp-bin:/tmp/bundle/programs/server/npm/node_modules/tiny-secp256k1/node_modules/.bin:/tmp/bundle/programs/server/npm/node_modules/.bin:/opt/Rocket.Chat/.nvm/versions/node/v14.18.2/lib/node_modules/npm/node_modules/npm-lifecycle/node-gyp-bin:/tmp/bundle/programs/server/npm/node_modules/tiny-secp256k1/node_modules/.bin:/tmp/bundle/programs/server/npm/node_modules/.bin:/opt/Rocket.Chat/.nvm/versions/node/v14.18.2/bin:/opt/Rocket.Chat/.nvm/versions/node/v14.18.2/lib/node_modules/npm/node_modules/npm-lifecycle/node-gyp-bin:/tmp/bundle/programs/server/node_modules/.bin:/opt/Rocket.Chat/.nvm/versions/node/v14.18.2/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin
9 verbose lifecycle [email protected]build: CWD: /tmp/bundle/programs/server/npm/node_modules/tiny-secp256k1
10 silly lifecycle [email protected]build: Args: [ '-c', 'node-gyp rebuild' ]
11 silly lifecycle [email protected]build: Returned: code: 1 signal: null
12 info lifecycle [email protected]build: Failed to exec build script
13 verbose stack Error: [email protected] build: node-gyp rebuild
13 verbose stack Exit status 1
13 verbose stack at EventEmitter. (/opt/Rocket.Chat/.nvm/versions/node/v14.18.2/lib/node_modules/npm/node_modules/npm-lifecycle/index.js:332:16)
13 verbose stack at EventEmitter.emit (events.js:400:28)
13 verbose stack at ChildProcess. (/opt/Rocket.Chat/.nvm/versions/node/v14.18.2/lib/node_modules/npm/node_modules/npm-lifecycle/lib/spawn.js:55:14)
13 verbose stack at ChildProcess.emit (events.js:400:28)
13 verbose stack at maybeClose (internal/child_process.js:1058:16)
13 verbose stack at Process.ChildProcess._handle.onexit (internal/child_process.js:293:5)
14 verbose pkgid [email protected]
15 verbose cwd /tmp/bundle/programs/server/npm/node_modules/tiny-secp256k1
16 verbose Linux 5.13.0-27-generic
17 verbose argv "/opt/Rocket.Chat/.nvm/versions/node/v14.18.2/bin/node" "/opt/Rocket.Chat/.nvm/versions/node/v14.18.2/bin/npm" "run" "build"
18 verbose node v14.18.2
19 verbose npm v6.14.15
20 error code ELIFECYCLE
21 error errno 1
22 error [email protected] build: node-gyp rebuild
22 error Exit status 1
23 error Failed at the [email protected] build script.
23 error This is probably not a problem with npm. There is likely additional logging output above.
24 verbose exit [ 1, true ]