Skip to content

[POTENTIAL BUG] Don't ask me again List only removes single option at a time. #17509

@TaimurAzhar

Description

@TaimurAzhar

Description:

I was testing the do not ask me again preferences when I found out that the don't ask me again list "select" field has the "multiple" attribute set to true but the JavaScript code written for its "Remove" button only removes one item from the list at a time. This is an inconsistency between the UI and the backend. Currently, no other modals exist with the "Don't ask me again" checkbox other than the "Hide Room" action so this issue is a potential future bug when the "don't ask me again" option is implemented for other modals.

Steps to reproduce:

Reproduction involves some manual addition to the code to emulate multiple options.

  1. Go to Preferences Page.
  2. Add an extra option in the select field for the "Don't ask me again list" preferences as such. (Can be done using browser tools or code)
  3. Try to choose multiple options in the list using "ctrl+click"/"cmd+click" to choose more than one.
  4. Click Remove.

Expected behavior:

When I select more than one item in the list and click Remove, all the selected items should be removed.

Actual behavior:

Choosing Multiple Options and clicking remove:
Screenshot 2020-05-02 at 4 29 54 PM

Removal of one of the options:
Screenshot 2020-05-02 at 4 30 26 PM

Server Setup Information:

  • Version of Rocket.Chat Server: 3.2.0-develop
  • Operating System: macOS 10.15.4
  • Number of Running Instances: 1
  • DB Replicaset Oplog: Enabled
  • NodeJS Version: 12.16.1
  • MongoDB Version: 4.0.6

Client Setup Information

  • Desktop App or Browser Version: Chrome Version 81.0.4044.129
  • Operating System: macOS 10.15.4

Additional context

I am not sure whether the "multiple" attribute was intended here in the first place to let users remove more than one item from the "don't ask me again list" in the future when possibly more modals have the "don't ask me again" checkbox option. However, this does seem like an intended feature for the "don't ask me again list" to have.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions