-
Notifications
You must be signed in to change notification settings - Fork 13.5k
[BUG] User Avatars broken in 3.1.0 if User Real Name in enabled #17243
Description
Description:
We have on-premise RC deployment with user created from corporate LDAP (Active Directory) where UserName it's a samaccuntname from LDAP and Name it's Surname Middle-name Name in LDAP
So we need to use option Admin UI - Layout - User Interface - User Real Name enabled, so our users can find each other by normal name or lastname.
After upgrade to 3.1.0 all user avatars in a sidebar was broken.
That because all user avatars are located in https://rc.company.com/avatar/username but after upgrade to 3.1.0 and with User Real Name enabled avatars are requested by https://rc.company.com/avatar/Surname Middle-name Name which is a obviously wrong URL.
Steps to reproduce:
- Set User Real Name to true on pre 3.1.0 version
- Set user avatard from LDAP
- Upgrade to 3.1.0
- No avatars in sidebar
Expected behavior:
Avatars should by requested by https://rc.company.com/avatar/username despite of User Real Name setting.
Actual behavior:
When User Real Name is disabled



Server Setup Information:
- Version of Rocket.Chat Server: 3.1.0
- Operating System: CentOS7
- Deployment Method: docker
- Number of Running Instances: 12
- DB Replicaset Oplog: Ebabled
- NodeJS Version: v12.16.1
- MongoDB Version: 4.0.16
Client Setup Information
- Desktop App or Browser Version: 2.17.9
- Operating System: Windows 10


