Skip to content

Rate limiter is set too high on the shields.svg API + Shield logo doesn't display correctly #14696

@wreiske

Description

@wreiske

Description:

We use multiple shields on a single web page to display links to common channels. On rare occasions, the shields don't display because the user has hit the rate limit on the shields API from viewing too many shields in a period of time.

The shield image is also not working correctly. It looks like it's pulling from "/assets/favicon.svg" in the actual SVG which won't work. It needs to have a full URL of the system.

Steps to reproduce:

  1. Create an html web page with multiple shields
  2. Reload the page
  3. Shields break

Expected behavior:

image
Note, the shield favicon isn't showing, but this is as close to expected as I could get

Actual behavior:

image

Server Setup Information:

  • Version of Rocket.Chat Server: 1.0.2 abf67ce

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions